Make Wrap Paragraph to Column action constrain wrapping to selected lines #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh my gosh, I totally missed your PR, @mikke89! Thanks so much for opening. I saw it tonight after finally getting tired of exactly the behavior you fixed and similarly fiddling with the gradle file. A lot. 😂 I ended up refactoring a few things in the plugin code to drop some deprecated usages that were throwing warnings. I'll compare your implementation with where I landed and see how they combine! |
abrookins
reviewed
Apr 25, 2024
| @@ -52,6 +52,7 @@ public void apply() { | |||
|
|
|||
| Objects.requireNonNull(settingsProvider.getState()).setColumnWidthOverride(columnWidth); | |||
| settingsProvider.getState().setUseMinimumRaggednessAlgorithm(useMinimumRaggednessAlgorithmCheckBox.isSelected()); | |||
| settingsProvider.getState().setPlaintextFileTypes(plaintextFileTypesField.getText()); | |||
|
No worries, please feel free to do whatever you wish with this PR. I'm just happy to see this extension continue to get support, it's really a must-have tool! :) |
|
Closing because I integrated this change into #60. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for this plugin. I made some changes, mostly to make the plugin work better for my own use cases.
I've also made some changes to the gradle build file to make it all compile for me.