Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'WARNING' target option is not properly propagated to compiler options #21

Closed
abdes opened this issue Sep 20, 2022 · 0 comments
Closed

'WARNING' target option is not properly propagated to compiler options #21

abdes opened this issue Sep 20, 2022 · 0 comments

Comments

@abdes
Copy link
Owner

abdes commented Sep 20, 2022

When a target is added using asap_add_library, asap_add_executable, ... with the WARNING option, that option is not properly propagated and the corresponding compiler behavior with regards to treating warnings as errors (or not) is not correct.
@abdes abdes changed the title WARNING target option is not properly propagated to compiler options 'WARNING' target option is not properly propagated to compiler options Sep 21, 2022
abdes added a commit that referenced this issue Sep 21, 2022
@abdes
fix(build): #21 target option WARNING not propagated properly
432cdaf 
By default, for every target we build, a compiler option will be added
to treat warnings as errors, unless the target is added with `WARNING` as
an option.

When that option is used, we now properly propagate it to set the
corresponding compiler option to **NOT** treat warnings as errors.

This is useful when 3rd party dependencies have include files that
generate warnings.
@abdes abdes closed this as completed Nov 28, 2022
@abdes abdes mentioned this issue Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abdes