-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Add Rust environment variables to Docker test workflows #9318
Open
gustavovalverde
wants to merge
3
commits into
main
Choose a base branch
from
fix-ci-test-all
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance test workflows by adding Rust-specific environment variables: - Include RUST_LOG for logging configuration - Add RUST_BACKTRACE and RUST_LIB_BACKTRACE for improved error tracing - Include COLORBT_SHOW_HIDDEN for detailed backtraces - Add CARGO_INCREMENTAL for build performance optimization These changes improve debugging capabilities and provide more flexibility in test environments across dockerized CI jobs.
Enable configurable Rust incremental compilation in Docker builds by: - Adding CARGO_INCREMENTAL as a build argument in GitHub Actions workflow - Setting a default value of 0 in Dockerfile to control build performance - Integrating with existing Rust environment variable configuration This change provides more granular control over Rust compilation strategies in containerized builds.
- Move WORKDIR after user creation to prevent home directory ownership issues - Properly set environment variables for UID, GID, HOME, and USER in each stage - Reorganize Dockerfile to ensure home directory is created after user setup - Fix interactive prompts during adduser by ensuring proper directory ownership
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-enhancement
Category: This is an improvement
C-exclude-from-changelog
Category: The PR should be excluded from the changelog and release notes
C-feature
Category: New features
I-usability
Zebra is hard to understand or use
P-High 🔥
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's hard to debug tests if we don't have access to the full backtrace and other options are expected to be set by our GitHub variables, but in the end not all of those are being fully used at runtime.
Solution
Enhance test workflows by adding Rust-specific environment variables:
RUST_LOG
for logging configurationRUST_BACKTRACE
andRUST_LIB_BACKTRACE
for improved error tracingCOLORBT_SHOW_HIDDEN
for detailed backtracesCARGO_INCREMENTAL
for build performance optimizationThis also fixes user creation issues in the Dockerfile:
Tests
Follow-up Work
PR Checklist
C-exclude-from-changelog
label.