Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(db): Use new bloom filter format for database index lookups #4041

Closed
wants to merge 2 commits into from
Closed

change(db): Use new bloom filter format for database index lookups #4041

wants to merge 2 commits into from

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Apr 5, 2022 •
edited
Loading

Motivation

This PR is exactly like PR #4032, but with the new bloom filter format, which should be more efficient.

Full sync test:

@teor2345 teor2345 added C-enhancement Category: This is an improvement P-Medium ⚡ A-state Area: State / database changes do-not-merge Tells Mergify not to merge this PR lightwalletd any work associated with lightwalletd labels Apr 5, 2022
@teor2345 teor2345 requested a review from a team as a code owner April 5, 2022 05:59
@teor2345 teor2345 self-assigned this Apr 5, 2022
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team April 5, 2022 05:59
@teor2345 teor2345 changed the title Rocksdb new bloom filter change(db): Use new bloom filter format for database index lookups Apr 5, 2022
@teor2345 teor2345 marked this pull request as draft April 5, 2022 08:41
@teor2345 teor2345 mentioned this pull request Apr 5, 2022
Merged
3 tasks
@teor2345 teor2345 closed this Apr 5, 2022
@teor2345 teor2345 closed this Apr 5, 2022
@teor2345 teor2345 deleted the rocksdb-new-bloom-filter branch September 5, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage was automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
A-state Area: State / database changes C-enhancement Category: This is an improvement do-not-merge Tells Mergify not to merge this PR lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teor2345