Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease DEFAULT_NULLIFIER_PROPTEST_CASES #2574

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Aug 6, 2021

Motivation

We want to reduce the amount of time the nullifier tests are taking.

Solution

Reduce the DEFAULT_NULLIFIER_PROPTEST_CASES from 16 to 2.

Review

Anyone can review

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

[add ticket for the other test cases taking too long]


This change is Reviewable

@teor2345 teor2345 merged commit 14532e4 into ZcashFoundation:main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants