Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update proto extract method / update protos to 2.300.x (breaking change, ready to merge) #894

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vinikjkkj
Copy link
Contributor

@vinikjkkj vinikjkkj commented Jun 26, 2024

Proto

This update will change access to proto properties, example (proto.Message will be proto.WAE2E.Message)

Proto Extract

Modified proto-extract from tulir's whatsmeow method, this version generates protos with extracted javascript modules from whatsapp web, no need to install third-party modules, only protobufjs-cli

Usage

  1. Download WhatsApp Web javascript modules to proto.js file in proto-extract folder

  2. Install protobufjs-cli with yarn or npm

  3. Open terminal shell in proto-extract folder

  4. Run generate.sh file

  5. This script will generate all protos and all statics .js and .ts

TODO

  • Fix export protos to use in baileys, in protos that have imports, there is conflicts with imported file. It can be fixed if we put all the protos in a single file, like the old one
  • Fix TS files generated from pbts
  • Update proto imports in baileys
  • Find some way to import namespaces to proto object

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@vinikjkkj/Baileys-Public#update-proto
# YARN v2
yarn add @whiskeysockets/baileys@vinikjkkj/Baileys-Public#update-proto

@purpshell
Copy link
Collaborator

will contribute here soon

@T3uZ
Copy link

T3uZ commented Aug 26, 2024

up

@vinikjkkj vinikjkkj changed the title update proto extract method / update protos to 2.300.x update proto extract method / update protos to 2.300.x (breaking change, ready to merge) Sep 12, 2024
@vinikjkkj vinikjkkj marked this pull request as ready for review September 12, 2024 18:42
@w3nder

This comment was marked as abuse.

@T3uZ
Copy link

T3uZ commented Oct 4, 2024

up

@canove
Copy link
Collaborator

canove commented Oct 4, 2024

@vinikjkkjV can you resolve the conflits so we can merge this?

@vinikjkkj
Copy link
Contributor Author

@vinikjkkjV can you resolve the conflits so we can merge this?

i don't know if purp will merge, apparently it's not how he wants, and he didn't tell me what should be changed, I'm not going to resolve conflicts without being sure it will be merged

Copy link

@qikerrs qikerrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up

Copy link

@qikerrs qikerrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up

@w3nder

This comment was marked as abuse.

@endriodev
Copy link

Up @purpshell

@nestordavalos
Copy link

up

@Lucas-Alves-Silva
Copy link

UP!

@HermesMacedo
Copy link

up @purpshell

@samuelrac
Copy link
Contributor

up @purpshell

@lucaspossam
Copy link

How can I download the protobuff from WhatsApp Web to test this PR? @vinikjkkj

@bentacos
Copy link

bentacos commented Dec 5, 2024

we need this. it seems that the proto is outdated in baileys

@T3uZ
Copy link

T3uZ commented Dec 5, 2024

UP @purpshell

@AnxHall
Copy link

AnxHall commented Dec 6, 2024

UP @purpshell

2 similar comments
@samuelrac
Copy link
Contributor

UP @purpshell

@gabrieldiaspereira
Copy link

UP @purpshell

Copy link
Collaborator

@purpshell purpshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with this course of development. We'll be releasing the WhiskeySocket's ProtoCocktail proprietary protobuf harvesting tool very soon. (this will also be the method determined by whatsmeow and Cobalt as well)

@purpshell purpshell marked this pull request as draft December 23, 2024 19:41
@purpshell purpshell added this to the ProtoCocktail milestone Mar 1, 2025
@purpshell purpshell force-pushed the master branch 2 times, most recently from 861e056 to af372f8 Compare March 6, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.