Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ubuntu version in ci to Ubuntu 24.04 #567

Conversation

mcbarton
Copy link
Contributor

@mcbarton mcbarton commented Feb 2, 2025

This PR updates the version of Ubuntu used in the ci to the latest version available for a Github runner Ubuntu 24.04.

@mcbarton
Copy link
Contributor Author

mcbarton commented Feb 3, 2025

@alexcrichton @sbc100 Does wasm-libc need libtinfo5 explicity, or can I update this PR to use libtinfo6 rather than the workaround currently in the PR?

@sbc100
Copy link
Member

sbc100 commented Feb 3, 2025

@alexcrichton @sbc100 Does wasm-libc need libtinfo5 explicity, or can I update this PR to use libtinfo6 rather than the workaround currently in the PR?

I believe the dependency on libinfo comes from clang/llvm not from wasi libc specifically. What happens if you simply remove the installation of libtinfo5? I assume some pre-built version of llvm will fail to execute?

@sbc100
Copy link
Member

sbc100 commented Feb 3, 2025

Yes, it looks like the step below downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-${{ matrix.clang_version }}/clang+llvm-${{ matrix.clang_version }}-${{ matrix.llvm_asset_suffix }}.tar.xz. Can you confirm that the version of llvm we are using still depends on libtinfo5?

@sbc100
Copy link
Member

sbc100 commented Feb 3, 2025

It looks like if we drop support for llvm versions old than 17 we could also drop support for tinfo5. As as long we want to continue to support llvm versions 16.0.0 and 10.0.0 then we should continue to test on the older version of ubuntu that has the right shared libraries.

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should close this PR and consider this again if/when we decide to drop support for older llvm versions.

@mcbarton
Copy link
Contributor Author

mcbarton commented Feb 3, 2025

Closing PR as requested, and will reopen if support for older versions of llvm are dropped.

@mcbarton mcbarton closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants