refactor: limit to 1M block transaction to get historical data in finance area #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `use-get-smart-wallet-transactions.ts`: - Added logic to dynamically fetch the starting block number using `publicClient.getBlockNumber` with a configurable offset (`GLOBAL_CONSTANTS.FROM_BLOCK`). - Refactored fromBlock assignment to use the fetched block number instead of a hardcoded value. - Improved error handling for block number fetch failures. - Updated `config-global.ts`: - Introduced a new global constant `FROM_BLOCK` to configure the starting block for fetching transactions. This change improves flexibility and enables querying specific block ranges dynamically.
- Removed a debug `console.log` statement from `finance-transactions-history.tsx`. - The cleanup ensures no unnecessary logs are left in production code. ```
- Updated `fromBlock` in `use-get-smart-wallet-transactions.ts` to default to `0n` if undefined. - This ensures that the hook functions correctly even when `fromBlock` is not provided.
- Updated FROM_BLOCK key in `src/config-global.ts` to use `VITE_FROM_BLOCK` instead of `VITE_BLOCK_FROM`. - This ensures consistency with the defined environment variable naming conventions.
|
geolffreym
requested changes
Mar 9, 2025
| @@ -101,17 +101,26 @@ export default function useGetSmartWalletTransactions() { | |||
| return; | |||
| } | |||
|
|
|||
| const fetchBlockNumber = async () => { | |||
| try { | |||
| return await publicClient.getBlockNumber().then((block) => BigInt(block - BigInt(GLOBAL_CONSTANTS.FROM_BLOCK))); | |||
There was a problem hiding this comment.
aca el await no es necesario..
| import {useDispatch, useSelector} from 'react-redux' | ||
| import {Address, formatUnits, parseAbiItem} from 'viem' | ||
| import {publicClient} from '@src/clients/viem/publicClient.ts' | ||
| import {GLOBAL_CONSTANTS} from '@src/config-global.ts' |
There was a problem hiding this comment.
constantes y abis moverlos al final de los imports por convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance functionality and code quality in the project. The most important changes include adding a new constant to the global configuration, updating the smart wallet transactions hook to fetch the block number dynamically, and removing an unnecessary console log statement.
> Should Add VITE_BLOCK_FROM=1000000 to .env files.
Enhancements to global configuration and hooks:
src/config-global.ts: AddedFROM_BLOCKconstant to handle block number configuration.src/hooks/protocol/use-get-smart-wallet-transactions.ts: Updated import statements formatting for consistency.src/hooks/protocol/use-get-smart-wallet-transactions.ts: Introduced a new functionfetchBlockNumberto dynamically fetch the block number and used it in the main function to set thefromBlockparameter.Code quality improvements:
src/sections/finance/components/finance-transactions-history.tsx: Removed an unnecessary console log statement for cleaner code.