This repository was archived by the owner on May 28, 2024. It is now read-only.
run models with tmmn and tmmx #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekoenig
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Looks good, @galengorski! I added just one (unrelated) question about the model config files. And I'm curious - can you tell if adding tmmn had any impact on the model performance?
| @@ -2,7 +2,7 @@ exp_name: "1b_multitask_do_gpp" | |||
|
|
|||
| site_set: "well_obs" | |||
There was a problem hiding this comment.
Not related to "tmmx" or "tmmn", but is there a reason we use "well_obs" for site_set here, but "med_obs" for the others?
I now see that you've included a few plots in #152 😊 |
lekoenig
reviewed
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in reference to #153 , running all four models with tmmx and tmmn. The PR updates the config files and the weights from the model runs