This repository was archived by the owner on May 28, 2024. It is now read-only.
Update p2a targets to use NHDv2 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galengorski
approved these changes
Jun 30, 2022
|
Thanks for reviewing these changes, @galengorski. I was able to build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the targets in p2a_model.R to use the NHDv2 attributes and met data, and also includes code changes to omit targets that use the NHM fabric (these are mostly in 1_fetch.R). @galengorski, these changes should resolve the error you point to in #142.
In p2a_model.R I did not make any changes to
p2a_model_ids, which is a list of lists containing the model names, snakefile directories, and config paths. I think this is OK, but let me know if you think we should edit or add to that target. Thanks!Closes #142
Closes #62
Closes #127