Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release event not available so use push event and filter #893

Merged
merged 31 commits into from
Jan 8, 2019
Merged

release event not available so use push event and filter #893

merged 31 commits into from
Jan 8, 2019

Conversation

johnnyreilly
Copy link
Member

@johnnyreilly johnnyreilly commented Jan 5, 2019 •
edited
Loading

  • publish event not available-switch to filter on push
  • need to get comparison tests passing in a docker container; got execution tests passing which is enough peace of mind to greenlight a release.

It looks like filtering makes subsequent actions in GitHub show as cancelled because the filter item has failed. That seems... Not quite right? Eg:

"Action publish' cancelled because action check for new tag' failed". Believe related to: https://github.com/actions/bin/issues/13

I'm just going to hack on this branch until I've got something I'm happy with. Then I will definitely squash and merge rather than just merge 😄

@johnnyreilly johnnyreilly mentioned this pull request Jan 5, 2019
Merged
@johnnyreilly
Run execution tests again
3c1fcc0
@johnnyreilly
Don't install pnpm globally
5507c28
@johnnyreilly
Use npx to run pnpm
4816b95
@johnnyreilly
Run Chrome no sandbox
8d0f21a
@johnnyreilly
More --no-sandbox
58a2b67
@johnnyreilly
create own dockerfile with node / chrome headless
a085064
@johnnyreilly
common karma.conf.js using ChromeHeadless --no-sandbox
be59bf8
@johnnyreilly
no sandbox on command line
8efb10c
@johnnyreilly
use alpine-chrome:with-node docker image
e3f7395
@johnnyreilly
back to the version that works
5cb183e
@johnnyreilly
drop node 6 from travis
17ad002
@johnnyreilly
try using node:10-slim
e03d27b
@johnnyreilly
start building and running in docker
1a55f40
@johnnyreilly
use full node image instead of slim for comparison tests
a4fc243
@johnnyreilly
set GITHUB_WORKSPACE = "/github/workspace/ts-loader"
1dd8f94
@johnnyreilly
close to being able to run comparison tests in docker container
e2a2a8e
@johnnyreilly
left a stray
f3dbf67
@johnnyreilly
tests pass in docker
9d230a3
@johnnyreilly
can comparison tests pass in a GitHub Action?
5e19487
@johnnyreilly
comparison tests will not pass in github action
e927275
@johnnyreilly
add docker:build step to package.json
b38f734
@johnnyreilly
Copy link
Member Author

I'm probably going to comment out the publish action of this workflow and merge. When the issue with the filter action is fixed then I can look to uncomment the publish step and enjoy the joys of automatic npm publishing 😁.

Either way, I'm happy with the work done in this PR and would like to merge it to master.

@johnnyreilly johnnyreilly merged commit df04a56 into master Jan 8, 2019
@johnnyreilly johnnyreilly deleted the fix-github-action-for-github-action-beta branch January 8, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnnyreilly