Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make YouTube plugin optional and add Invidious plugin support #41

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

basilgello
Copy link
Contributor

I got fed up with YT plugin Google Cloud mess and switched to Invidious plugin. Works great with patches I PR'd here and there :)

Note: I had to change "preferYoutubeAddon" type from "bool" to "select" and add "Invidious" and "YouTubeDL" choices. The default choice is still "YouTube" but users who had it turned off will likely need to re-visit plugin settings. If there is a better migration path, please advise.

@Tolriq
Copy link
Owner

Tolriq commented Sep 24, 2023

Thanks.

To avoid migration errors as I don't know how it's handled by Kodi, you should rename the option "preferYoutubeAddon" to "preferedYoutubeAddon" to start fresh.

Can you also update the label? And update the values="YouTube|Invidious|YouTubeDL" the "YouTubeDL" should probably be "None" if I ever change the engine and better reflect the setting.

@basilgello
Copy link
Contributor Author

Done!

@basilgello
Copy link
Contributor Author

PS: please verify I translated the French label correctly :) I will proofread Russian translation as it sounds weird

@Tolriq
Copy link
Owner

Tolriq commented Sep 24, 2023

Thanks, there's no "L'" at the start in the French one, but I can update locally later.

Will test and merge probably only tomorrow but LGTM.

... plugin support.

  * Changed 'preferYoutubeAddon' bool setting to selector
    with 'YouTube' setting as default choice

Signed-off-by: Vasyl Gello <[email protected]>
@basilgello
Copy link
Contributor Author

Updated once more: the label and the additional clause to filter out urls like 'v=blahblah&t=0' or other params following the video id.

@basilgello
Copy link
Contributor Author

If Invidious plugin version from Kodi repo fails to resolve the final stream URL, it may be related to petterreinholdtsen/kodi-invidious-plugin#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants