Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation: consider +, - and ' as a valid separators for character name words #306

Merged
merged 2 commits into from
Dec 25, 2023
Merged

validation: consider +, - and ' as a valid separators for character name words #306

merged 2 commits into from
Dec 25, 2023

Conversation

phenpessoa
Copy link
Contributor

fixes #305

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@phenpessoa phenpessoa changed the title validation: consider + as a valid separator for character name words validation: consider +, - and ' as a valid separators for character name words Dec 25, 2023
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Dec 25, 2023
tobiasehlert
tobiasehlert approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@tobiasehlert tobiasehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐ 🎄

@tobiasehlert tobiasehlert merged commit d0b5d51 into TibiaData:main Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasehlert tobiasehlert tobiasehlert approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

+ character is being counted towards character name 'word limit'
2 participants
@phenpessoa @tobiasehlert