x86-64 48-bit pointer optimization for GenericValue #546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #330
In x86-64 platform,
RAPIDJSON_48BITPOINTER_OPTIMIZATION
is turned on by default.This reduces the
sizeof(GenericValue)
from 24 bytes to 16 bytes.It is interesting to show that, although there is additional calculation for those pointers, the performance does improved due to reduce memory size.
This PR also reduces
flags
inGenericValue
from 32-bit to 16-bit and rearrange the layout. This will also benefit for other platforms, in which theShortString
can store more characters than before.