GenericValue: improve copying performance #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GenericValue "copy" constructor (with Allocator) uses a temporary GenericDocument object to perform the deep copying with the provided allocator. This leads to the temporary allocation of the `Stack` memory, even in case of shallow values (numbers, etc.). This patch improves the performance of this operation by only resorting the the SAX Handler implementation in case of Array or Object values.
miloyip
added a commit
that referenced
this pull request
Nov 28, 2014
GenericValue: improve copying performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenericValue"copy" constructor (with Allocator, see #20) uses a temporaryGenericDocumentobject to perform the deep copying with the provided allocator. This leads to the temporary allocation of theStackmemory, even in case of shallow values (numbers, etc.).This patch improves the performance of this operation by only resorting the the SAX
Handlerimplementation in case of Array or Object values.