Fix duplicate menu options in ChannelFragment #12083
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
ShareASmile
added
bug
This comment has been minimized.
This comment has been minimized.
|
Duplicate menu options are fixed, but now if you perform the back gesture the buttons on the top right disappear. newpipe.mp4newpipe2.mp4 |
snaik20
reviewed
Mar 9, 2025
| @Override | ||
| public void onDestroyView() { | ||
| super.onDestroyView(); | ||
| if (menuProvider != null) { |
There was a problem hiding this comment.
Maybe add this check in onCreate, so that it doesn't add a duplicate menu if one is already added for the channel fragment
AudricV
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
MenuProvider is being added in onCreate, but it’s only removed in onDestroy. If the fragment is recreated (e.g., due to configuration changes), the menu Provider might be added again without being properly removed first, leading to duplicate menu items.
Before/After Screenshots/Screen Record
Before :
After :
Fixes the following issue(s)