fix(form-core): #1182 remove stale form level validation errors. Main…

[juanvilladev]

…tain cummulative errorMap instead of snapshot of previous validation cycle.

Problem
Currently, prevFieldsErrorMap, was being assigned to the current validation cycle's newErrorMap see here. This caused issues because when we run the validator we do not receive a value for fields with no errors. This meant that on subsequent validation cycles, when the error was cleared, our prevFieldsErrorMap did NOT have a value for the field thus not clearing the error when this loop executes.

Changes

1. Renamed prevFieldsErrorMap to cumulativeFieldsErrorMap to better reflect its purpose
2. Updated JSDoc comments to clearly explain the data structure's role
3. Update cumulativeFieldsErrorMap as we iterate through the new field errors and through error clearing loops. Ensuring we're accumulating the validations not simply assigning the new field errors like we were before!
4. Added a test that will explicitly check for the new behavior and tackle the exact example provided on Form-level validation does not always clear errors #1182
5. Additionally, I made sure that we're setting the map and doing updates within the batch calls to ensure we don't hit weird race conditions.

Previously we would set prevFieldsErrorMap to an empty object if no fieldErrors on current cycle. With these changes now we set it to:

   {
      firstName: {
        onChange: undefined,
      },
      lastName: {
        onChange: undefined,
      },
    }

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 6edfc44.

Command	Status	Duration	Result
nx affected --targets=test:sherif,test:knip,tes...	✅ Succeeded	2m 2s	View ↗
nx run-many --target=build --exclude=examples/**	✅ Succeeded	23s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-03-01 07:15:38 UTC

[pkg-pr-new]

Open in Stackblitz

More templates

• @tanstack/form-example-angular-array
• @tanstack/form-example-angular-simple
• @tanstack/form-example-lit-simple
• @tanstack/form-example-lit-ui-libraries
• @tanstack/form-example-react-array
• @tanstack/form-example-react-compiler
• @tanstack/field-errors-from-form-validators
• @tanstack/form-example-react-next-server-actions
• @tanstack/form-example-react-query-integration
• @tanstack/form-example-remix
• @tanstack/form-example-react-simple
• @tanstack/form-example-react-standard-schema
• @tanstack/form-example-react-tanstack-start
• @tanstack/form-example-react-ui-libraries
• @tanstack/form-example-solid-array
• @tanstack/form-example-solid-simple
• @tanstack/form-example-vue-array
• @tanstack/form-example-vue-simple

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1186

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1186

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1186

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1186

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1186

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1186

commit: 6edfc44

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (0734926) to head (6edfc44).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   88.49%   88.50%           
=======================================
  Files          28       28           
  Lines        1252     1253    +1     
  Branches      326      327    +1     
=======================================
+ Hits         1108     1109    +1     
  Misses        129      129           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.