Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spksrc.native-cmake.mk #4321

Closed
wants to merge 2 commits into from
Closed

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Dec 20, 2020

Motivation: Some native package requires cmake to be built. New Makefile definitions helpers allows building them easily. Included in this PR is an example to build ninja using spksrc.native-cmake*.mk helper files.
Linked issues: #4307

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Important note

The usage of a specific native/cmake version is not mandatory as default Debian image already provides one. In the example provided ninja needed an earlier version thus spksrc.native-cmake-env.mk helper code make usage of the following:

# Use native cmake
DEPENDS += native/cmake
CMAKE_PATH = $(WORK_DIR)/../../../native/cmake/work-native/install/usr/local/bin
ENV += PATH=$(CMAKE_PATH):$$PATH

If this PR is being merge, the usage of native/cmake within spksrc.native-cmake*.mk could in theory be discarded.

@th0ma7 th0ma7 requested a review from ymartin59 December 20, 2020 20:04
@th0ma7 th0ma7 self-assigned this Dec 20, 2020
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Dec 20, 2020
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Dec 20, 2020
@th0ma7 th0ma7 changed the title cmake native makefile spksrc.native-cmake.mk Dec 27, 2020
@hgy59
Copy link
Contributor

hgy59 commented Dec 28, 2020

@th0ma7 is there a reason not to remove the installed cmake completely (from Dockerfile) and only use native/cmake?
This would keep the .mk files clean (avoid spksrc.native-cmake.mk files)

Edit:
ooh, I see, it takes a long time to build CMake from scratch.
and I have to search the comments here, why not taking the debian buster backport CMake v3.16.3

@th0ma7
Copy link
Contributor Author

th0ma7 commented Dec 28, 2020

@hgy59 it all started with the need of having native/ninja which in turns needed a spksrc.native-cmake.mk so I could build native package using cmake. It turned out that ninja also needed a newer version of cmake which led to the addition of native/cmake as well.

In the end the default Debian ninja works great so there is no need for neither native/ninja or native/cmake. Althgouh the spksrc.native-cmake*.mk can still be of interest. Question is: what to do about them?

Personally I would (and had done previously):

  • remove native/ninja and native/cmake
  • remove references to native/cmake in spksrc.native-cmake*.mk
  • keep the spksrc.native-cmake*.mk

But then again, without any examples or usages, is it really worth it? @ymartin59 was suggesting to just be keeping the PR alive in case we ever need it.

@hgy59
Copy link
Contributor

hgy59 commented Dec 28, 2020

@ymartin59 was suggesting to just be keeping the PR alive in case we ever need it.

you can create a branch like native-cmake in this repo (similar as we have dsm7 branch) and create and merge a PR with the spksrc.native-cmake*.mk files there, so these are not lost.

@th0ma7 th0ma7 mentioned this pull request Apr 8, 2021
3 tasks
@hgy59 hgy59 mentioned this pull request Jun 13, 2021
6 tasks
@hgy59 hgy59 closed this in #4674 Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants