Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Steam enums #685

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Add new Steam enums #685

merged 2 commits into from
Aug 6, 2019

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented May 23, 2019 •
edited
Loading

Added new enums that would make sense, and ignored some that would be of no use (like all the enums of help issues, etc)

@voided
Copy link
Member

voided commented May 23, 2019

Were there any new EMsgs by chance?

@xPaw
Copy link
Member Author

xPaw commented May 23, 2019

Updated EMsgs

@yaakov-h yaakov-h added this to the 2.3.0 milestone May 24, 2019
Ne3tCode
Ne3tCode suggested changes May 24, 2019
View reviewed changes
Copy link

@Ne3tCode Ne3tCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incorrect. xPaw can't into parsing 😄
https://gist.github.com/Ne3tCode/78b3f5b6d980919fa5b5be1e41356a41#file-dump-json

Ne3tCode
Ne3tCode approved these changes May 24, 2019
View reviewed changes
Copy link

@Ne3tCode Ne3tCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good now. 👍

voided
voided requested changes May 25, 2019
View reviewed changes
Resources/SteamLanguage/emsg.steamd Outdated
@@ -1883,8 +1933,8 @@ enum EMsg
SLCSharedLibraryChanged = 9408;

RemoteClientBase = 9500;
RemoteClientAuth = 9500;
RemoteClientAuthResponse = 9501;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these without marking them as removed or renamed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theye're marked as removed anyway, does it matter to leave old one in place with removed+renamed comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case someone happened to be using that EMsg so that we don't break them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed entries are not generated into C#

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obsolete generates C#, removed does not.

@Ne3tCode
Copy link

New EMsg:

ClientChallengeRequest = 5623;
ClientChallengeResponse = 5624;
ClientMMSSetRatelimitPolicyOnClient = 6625;
ClientMMSGetLobbyStatus = 6626;
ClientMMSGetLobbyStatusResponse = 6627;

Removed from mobile chat js:

MDSGetServerListForUser = 5836;
MDSGetServerListForUserResponse = 5837;

@xPaw
Copy link
Member Author

xPaw commented Jul 17, 2019

I removed EMsg from this PR, and added some new values.

@Ne3tCode
Copy link

EClientPersonaStateFlag.ClanTag renamed to ClanData

@xPaw
Copy link
Member Author

xPaw commented Aug 5, 2019

Anything blocking this from merging?

@yaakov-h
Copy link
Member

yaakov-h commented Aug 6, 2019

image

@yaakov-h yaakov-h merged commit 1d0a2ce into SteamRE:master Aug 6, 2019
@xPaw xPaw deleted the xpaw/enums branch August 6, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaakov-h yaakov-h yaakov-h approved these changes

@voided voided voided requested changes

@Ne3tCode Ne3tCode Ne3tCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@xPaw @voided @Ne3tCode @yaakov-h