Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/v1/rules API endpoint action parameters secrets masking (additional changes on top of #4788) #4807

Merged
merged 48 commits into from
Oct 30, 2019

Conversation

Kami
Copy link
Member

@Kami Kami commented Oct 29, 2019

This pull request includes some additional changes and improvements on top of #4788.

I couldn't push directly to that fork branch so I needed to open a new PR.

Changes are described here - #4788 (comment).

Resolves #4788.

jeansfelix and others added 30 commits September 12, 2019 11:54
…rs for test_get_all_parameters_mask_with_include_parameters and test_get_one_parameters_mask_with_exclude_parameters for test_get_all_parameters_mask_with_exclude_parameters
… and test_get_all_parameters_mask_with_exclude_parameters
@Kami Kami added this to the 3.2.0 milestone Oct 29, 2019
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Oct 29, 2019
@Kami Kami changed the title Additional changes on top of #4788 /v1/rules API endpoint action parameters secrets masking (additional changes on top of #4788) Oct 29, 2019
Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service: api size/L PR that changes 100-499 lines. Requires some effort to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants