Update the requests library version to latest (2.22.0) in requirements

[VineeshJain]

This PR updates the requests package version to the latest (2.22.0) - Closes #4680

[CLAassistant]

All committers have signed the CLA.

[m4dcoder]

@VineeshJain Please fix the commits here. You should have rebased the first commit, amend the title for the commit, and then push it back into the feature branch. This is such a small change. The additional commits are needless and pollutes the commit history. Also, please fix the PR title appropriately. Which module are you updating in requirements? The PR title doesn't mention which module we are updating.

[m4dcoder]

@VineeshJain Can you run make distclean and make requirements locally and see if additional files are updated. There are other requirements.txt that gets updated automatically when running make requirements. Those auto updated files need to be included in the PR.

[VineeshJain]

@m4dcoder I did make requirements which gave me 3 additional files other than the fixed-requirements.txt file. I committed all 4 of them. Just now I again did make distclean and then make requirements. No new files came in. This is the output after make distclean and make requirements

vagrant@ubuntu-xenial:~/st2$ git status
On branch issue-4680/DependencyUpgradeRequests
Your branch is up-to-date with 'origin/issue-4680/DependencyUpgradeRequests'.
nothing to commit, working directory clean
vagrant@ubuntu-xenial:~/st2$

[m4dcoder]

@VineeshJain Ok thanks for confirming.

[m4dcoder]

Please rebase this feature branch with master and then push again. I will approve after.

[m4dcoder]

Please also add a CHANGELOG entry.

[m4dcoder]

LGTM. Please also get an approval from @Kami since he may have other concerns.

[VineeshJain]

Thanks. Will request @Kami for a review before merging.

[Kami]

LGTM.

Let's please just make sure it's tested end to end on all the supported distros (RHEL 6, RHEL 7, Ubuntu 14.04, 16.04 and 18.04).

Please also test it in combination with some packs which explicitly specify version of requests in requirements.txt to make sure that there are no conflicts.

On a related note - we may just want to remove version specifier from all the pack requirements.txt files to make sure it doesn't conflict with StackStorm one..

kami ~/w/stackstorm/exchange-all $ ag requests | grep requirements
stackstorm-newrelic/requirements.txt:2:requests
stackstorm-octopusdeploy/requirements.txt:1:requests
stackstorm-lastline/requirements.txt:1:requests>=2.7.0,<3.0
stackstorm-check_mk/requirements.txt:1:requests
stackstorm-gitlab/requirements.txt:1:requests
stackstorm-mistral/requirements.txt:1:requests>=2.5.1
stackstorm-salt/requirements-tests.txt:1:requests-mock
stackstorm-salt/requirements.txt:3:requests
stackstorm-tuleap/requirements.txt:1:requests>=2.7.0,<3.0
stackstorm-cloudshark/requirements.txt:1:requests
stackstorm-reamaze/requirements.txt:1:requests>=2.8.1,<3.0
stackstorm-webpagetest/requirements.txt:1:requests>=2.6.0,<3.0
stackstorm-smartthings/requirements.txt:1:requests>=2.5,<3.0
stackstorm-exos/requirements.txt:1:requests
stackstorm-github/requirements.txt:3:#requests>=2.5.1,<2.6
stackstorm-opsgenie/requirements-tests.txt:1:requests-mock
stackstorm-mmonit/requirements.txt:1:requests>=2.6.0,<3.0
stackstorm-opscenter/requirements.txt:2:requests
stackstorm-dripstat/requirements.txt:1:requests>=2.5.1
stackstorm-puppet/requirements.txt:1:requests>=2.5.0,<3.0
stackstorm-ipcam/requirements.txt:1:requests
stackstorm-network_essentials/requirements.txt:3:requests==2.18.4
stackstorm-travis_ci/requirements.txt:1:requests
stackstorm-hubot/requirements.txt:1:requests
stackstorm-vadc/requirements.txt:1:requests
stackstorm-fireeye/requirements.txt:1:requests>=2.7.0,<3.0
stackstorm-google/requirements.txt:1:requests
stackstorm-prometheus/requirements.txt:1:requests
stackstorm-mailgun/requirements.txt:1:requests>=2.5.0,<3.0
stackstorm-circle_ci/requirements.txt:1:requests
stackstorm-slack/requirements.txt:1:requests>=2.5.0,<3.0
stackstorm-packagecloud/requirements.txt:1:requests
stackstorm-device42/requirements.txt:1:requests>=2.11.1
stackstorm-windows/requirements.txt:4:requests_ntlm
stackstorm-ghost2logger/requirements.txt:3:requests
stackstorm-netbox/requirements.txt:1:requests
stackstorm-nagios/requirements.txt:2:requests[security]>=2.7.0

[VineeshJain]

Yes, I tested end to end explicitly for RHEL6, RHEL7. Commit tested end to end for centos7, Ubuntu 16 and Ubuntu 18. I will run the test explicitly for Ubuntu 14