Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some actions which are related to deal with host object #35

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

userlocalhost
Copy link
Collaborator

@userlocalhost userlocalhost commented Aug 20, 2019

Summary

This adds some actions which are related to deal with host object via primitive implementation that sends a request to specified API endpoint with other specified parameters.

Changes

  • actions/call_api.py - A primitive implementation of python-script to send a request to specified API endpoint with other specified parameters.
  • actions/list_host_groups.yaml - List all host_groups objects which are registered in Zabbix
  • actions/list_host_interfaces.yaml - List all hostinterfaces objects which are registered in Zabbix
  • actions/list_hosts.yaml - List all host objects which are registered in Zabbix
  • actions/list_templates.yaml - List all templates objects which are registered in Zabbix
  • actions/update_host.yaml - A primitive action to update host information

primitive implementation that sends a request to specified API endpoint
with other specified parameters.
@userlocalhost
Copy link
Collaborator Author

userlocalhost commented Aug 21, 2019

Thank you for your review, @blag.

I fixed this vulnerable code to other one which is more decent and safe on the basis of your advice.
It was ended up to being longer than I expected. Because most of API methods consist of a couple of attributes, we need to check each attribute is valid.

@blag blag self-requested a review August 23, 2019 19:10
@blag
Copy link
Contributor

blag commented Aug 23, 2019

Fixed the pack CI in the ST2 repository and reran tests.

Thanks for the contribution!

@blag blag merged commit 93ff826 into master Aug 23, 2019
@blag blag deleted the feature/actions branch August 23, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants