Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENV] Add support for passing the coveralls token via an env var #75

Merged
merged 2 commits into from
May 8, 2015

Conversation

orta
Copy link
Contributor

@orta orta commented Apr 27, 2015

Note: this happens to me locally too, #74
Re: #68 - I've added support for using an ENV var to pass your token in. Called it Coverage so that it can fit the other providers too.

@marklarr
Copy link
Contributor

marklarr commented May 1, 2015

Can we change it to CI_ACCESS_TOKEN? COVERAGE_ACCESS_TOKEN I would expect to be the token for Coveralls if you have Coveralls Pro. This token is the token for travis/circle ci when you have their pro.

@orta
Copy link
Contributor Author

orta commented May 2, 2015

I thought that originally, but the token is the coveralls token as opposed to the one for the CI. Calling it the CI_ACCESS_TOKEN implies that would you find it at travis/circle when you have to get it from coveralls.

Happy to switch though, I have no horse in this race.

@marklarr
Copy link
Contributor

marklarr commented May 2, 2015

Oh, you're right, I just looked back at #17. That is the token that comes from Coveralls, not Travis. can you change the other variables to coverage_access_token, in that case, for consistency? 😁

@orta
Copy link
Contributor Author

orta commented May 8, 2015

done 👍

@marklarr
Copy link
Contributor

marklarr commented May 8, 2015

Sweet, thanks orta!

marklarr added a commit that referenced this pull request May 8, 2015
[ENV] Add support for passing the coveralls token via an env var
@marklarr marklarr merged commit 8219fdd into SlatherOrg:master May 8, 2015
@orta
Copy link
Contributor Author

orta commented May 8, 2015

@chrismaddern - this probably breaks your current install ^

@marklarr
Copy link
Contributor

marklarr commented May 8, 2015

I'll have to do a minor version update. Hopefully this doesn't affect too
many ppl.

On Friday, May 8, 2015, Orta [email protected] wrote:

@chrismaddern https://github.com/chrismaddern - this probably breaks
your current install ^


Reply to this email directly or view it on GitHub
#75 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants