Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multiple region data #484

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Fix for multiple region data #484

merged 1 commit into from
Mar 16, 2021

Conversation

fchiba
Copy link
Contributor

@fchiba fchiba commented Mar 15, 2021

This PR is intended to fix #481

If we want [[a,b],[c,d]] from [[a,b]] and [c,d], we should use <<.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 96.222% when pulling a68a40f on fchiba:fix-481 into 1abd2a3 on SlatherOrg:master.

@ksuther
Copy link
Contributor

ksuther commented Mar 15, 2021

@hborawski Would love your feedback on this since it was your PR. Thanks!

@hborawski
Copy link
Contributor

the test looks good, and im no ruby master, so if that operator is better for this then 👍

@ksuther ksuther merged commit 5a08fb3 into SlatherOrg:master Mar 16, 2021
@ksuther
Copy link
Contributor

ksuther commented Mar 16, 2021

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML report fails to generate on 2.7.0 with xcode 12.4
4 participants