Add Branch Coverage data for ProfData coverage files #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksuther
reviewed
Mar 4, 2021
There was a problem hiding this comment.
Thanks for the PR! I made some incredibly nitpicky suggestions just to match the existing code style.
I'm by no means a Ruby pro either, so if anyone else has any suggestions feel free to chime in. Otherwise if it's working on your code base and the tests are passing I'm happy to merge this in and cut a release.
|
Updated the code to use snake case for all the variables, didn't even realize the rest of the codebase was snake 🤦 |
|
Merged, thanks for the contribution! I'll make a release to include this. |
|
Happy to help, and excited to get all my projects updated with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the lcov json data segments, populate
branch_coverage_datafor profdata coverage filesThis allows the cobertura report to correctly calculate branch coverage
Also added branch coverage to the HTML output by using the segments to determine column ranges that were not hit, so null coalesecing operations, or other single line branches can be determined as missed coverage.
Please let me know if there are any updates required for this PR, it's been quite some time since using ruby, so I'm sure the code can be improved.
I made sure the existing tests pass, and i added some small profdata tests to check that the branch data populates as expected.
I've also tested this locally against a real project and compared output to Xcode, to see how it works on a larger codebase.
Example of a covered line with an uncovered branch:
