Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "No coverage directory found." instead of "implicit conversion nil into String" #341 #381

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Show "No coverage directory found." instead of "implicit conversion nil into String" #341 #381

merged 1 commit into from
Nov 13, 2018
+1 −1

Conversation

phimage
Copy link
Contributor

@phimage phimage commented Apr 10, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.732% when pulling 2ebb914 on phimage:patch-1 into 036f147 on SlatherOrg:master.

dnedrow
dnedrow approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@dnedrow dnedrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable.

@ksuther , what do you think?

@ksuther
Copy link
Contributor

ksuther commented Nov 13, 2018

Looks good to me too. Thanks for the extra set of eyes @dnedrow!

@ksuther ksuther merged commit 1bb36e4 into SlatherOrg:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnedrow dnedrow dnedrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phimage @coveralls @ksuther @dnedrow