-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single source file in binary predicate #377
Fix single source file in binary predicate #377
Conversation
Fixing SlatherOrg#376 issue.
706a7ec
to
4fa17e2
Compare
@ksuther could you please take a look when you have time? Thank you! |
Will do, thanks for the PR! |
Thank you! |
Awesome work, would be great to get a release for this! |
Seems not to work for me. I found three places in code that needs to be fixed:
|
@jn-se I have a similar problem on Xcode 9.3.1 now, investigating now |
I also have the same issue on 9.3.1 |
Same here. I'm on 9.3.1. and getting |
Fixing #376 issue.
“ 1| <NUMBER>|<CODE>”
line (corresponds to Xcode 9.3xcrun llvm-cov show
output) should be detected as!path_on_first_line?
. Previouspath_on_first_line?
implementation returnstrue
for that example failing to process single source binary.