Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .dSYM and .swiftmodule files filtering in find_binary_files() #368

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

krin-san
Copy link
Contributor

@krin-san krin-san commented Feb 13, 2018

search_list.each ... .reject doesn't work at all due to incorrectly written multiline reject block. On my project slather crashes trying to call split on nil and apparently it allowed to pass .dSYM paths to matches_arch function.

I noticed this issue when I built an app using Debug configuration for Generic iOS Device. After that slather crashed trying to lipo nil because .dSYM is a folder and find_binary_file_in_bundle returned nil for it.

Simplified demo on current implementation and two ways to write that right: https://repl.it/repls/BonyConsiderateModel

@coveralls
Copy link

coveralls commented Feb 13, 2018

Coverage Status

Coverage increased (+0.002%) to 95.732% when pulling f0b16e8 on krin-san:bugfix/find_binary_files.reject into aadb417 on SlatherOrg:master.

@krin-san krin-san force-pushed the bugfix/find_binary_files.reject branch from 19fabdb to f0b16e8 Compare February 13, 2018 10:17
@ksuther ksuther merged commit 0e2a2d9 into SlatherOrg:master Feb 13, 2018
@ksuther
Copy link
Contributor

ksuther commented Feb 13, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants