Fix .dSYM and .swiftmodule files filtering in find_binary_files() #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_list.each ... .reject
doesn't work at all due to incorrectly written multilinereject
block. On my project slather crashes trying to callsplit
onnil
and apparently it allowed to pass.dSYM
paths tomatches_arch
function.I noticed this issue when I built an app using Debug configuration for Generic iOS Device. After that slather crashed trying to
lipo nil
because.dSYM
is a folder andfind_binary_file_in_bundle
returnednil
for it.Simplified demo on current implementation and two ways to write that right: https://repl.it/repls/BonyConsiderateModel