Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple JSON output. #318

Merged
merged 2 commits into from
Jun 11, 2017
Merged

Simple JSON output. #318

merged 2 commits into from
Jun 11, 2017

Conversation

ileitch
Copy link
Contributor

@ileitch ileitch commented Jun 8, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.702% when pulling aa244fd on ileitch:json-output into f0b4415 on SlatherOrg:master.

@ksuther
Copy link
Contributor

ksuther commented Jun 9, 2017

Thanks for the PR! What is the JSON output used for? Is it for an input to another internal tool or is there some service that uses JSON as the input format?

@ileitch
Copy link
Contributor Author

ileitch commented Jun 9, 2017

I'm using it to communicate with Coveralls directly outside of Slather, as Slather wasn't quite appropriate for my use case.

I figured since it's also super basic, it might be useful for other people to use as a basis if Slather doesn't already support their desired format.

@ksuther
Copy link
Contributor

ksuther commented Jun 10, 2017

Got it, thanks. Good to have a use case documented in case anyone else stumbles upon it later.

Could you update the changelog in the PR and I'll merge it?

@ileitch
Copy link
Contributor Author

ileitch commented Jun 10, 2017

Updated.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.702% when pulling 23ba9a4 on ileitch:json-output into f0b4415 on SlatherOrg:master.

@ksuther ksuther merged commit fad27c2 into SlatherOrg:master Jun 11, 2017
@ksuther
Copy link
Contributor

ksuther commented Jun 11, 2017

Thanks!

@ileitch ileitch deleted the json-output branch June 11, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants