Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project.rb #229

Closed
wants to merge 1 commit into from
Closed

Update project.rb #229

wants to merge 1 commit into from

Conversation

djmars23
Copy link

@djmars23 djmars23 commented Jun 12, 2016

Look at issue #225 "input_format in .slather.yml is not being used".

I have older gcov coverage using 7.3.1 and it keeps switching to profdata. I have define the following in .slather.yml:

coverage_service: cobertura_xml
input_format: gcov
xcodeproj: Lib.xcodeproj
scheme: LibTests
source_directory: Lib
output_directory: ./TempTest/slather
ignore:
  - LibApp/*
  - LibTests/*

I think you might need to change:
self.input_format ||= self.class.yml["input_format"] || input_format

to

self.input_format = self.class.yml["input_format"] || self.input_format || input_format

This will give flexibility to generate based on correct needed input.

Look at issue 225 "input_format in .slather.yml is not being used".
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.15% when pulling c947c80 on djmars23:patch-1 into 1a7dff6 on SlatherOrg:master.

@bootstraponline
Copy link
Member

It'd be nice to have a test to verify the input_format initialization logic doesn't regress in the future.

@djmars23
Copy link
Author

When will this be pushed to master?

@bootstraponline
Copy link
Member

When will this be pushed to master?

I still don't see a test?

@djmars23
Copy link
Author

Where can I put the test?

@bootstraponline
Copy link
Member

bootstraponline commented Jun 20, 2016

Where can I put the test?

slather/spec/slather/project_spec.rb

@bootstraponline
Copy link
Member

looks like this has been fixed by #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants