Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Postgre function: DATE_TRUNC #825

Merged
merged 7 commits into from
Feb 16, 2025
Merged

Add Postgre function: DATE_TRUNC #825

merged 7 commits into from
Feb 16, 2025

Conversation

IgnisDa
Copy link
Contributor

@IgnisDa IgnisDa commented Oct 5, 2024

PR Info

This PR adds the DATE_TRUNC functions along with docs and tests.

Additional

N/A

@IgnisDa IgnisDa changed the title Add Postgres Json functions: DATE_TRUNC Add Postgre function: DATE_TRUNC Oct 5, 2024
@IgnisDa
Copy link
Contributor Author

IgnisDa commented Oct 5, 2024

@tyt2y3 Could you take a look at this PR? Thanks!

ikrivosheev
ikrivosheev reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgnisDa hello! Thank you for the PR. Little comment)

ikrivosheev
ikrivosheev reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment)

ikrivosheev
ikrivosheev approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgnisDa thank you! LGTM!

tyt2y3
tyt2y3 reviewed Feb 16, 2025
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tyt2y3 tyt2y3 merged commit e03e987 into SeaQL:master Feb 16, 2025
20 checks passed
@github-actions GitHub Actions
Copy link

🎉 Released In 0.32.2 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 left review comments

@ikrivosheev ikrivosheev ikrivosheev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IgnisDa @tyt2y3 @ikrivosheev