Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion.menu.draw.treesitter should only affect items from the LSP source #438

Closed
chrisgrieser opened this issue Dec 3, 2024 · 1 comment · Fixed by #526
Closed
Labels
feature New feature or request windows Module which displays UI

Comments

@chrisgrieser
Copy link
Contributor

chrisgrieser commented Dec 3, 2024

Feature Description

Just discovered the feature, and I quite like it. However, by applying it to all items, you also get a lot of spurious highlighting of words such as in or file, often used for example in names of snippets.

I think limiting the highlighting to items from the LSP source only would produce the best result by highlighting the correct things, while not highlighting things that are not are nor code.

Pasted image 2024-12-03 at 19 48 48

@chrisgrieser chrisgrieser added the feature New feature or request label Dec 3, 2024
@Saghen Saghen changed the title FR: completion.menu.dra.treesitter should only affect items from the LSP source completion.menu.draw.treesitter should only affect items from the LSP source Dec 5, 2024
@Saghen Saghen added the windows Module which displays UI label Dec 5, 2024
@Saghen
Copy link
Owner

Saghen commented Dec 6, 2024

For anyone looking to implement this, the treesitter option should be changed to accept a table of source_ids that it applies to. The documentation should then recommend treesitter = { "lsp" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request windows Module which displays UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants