Screen flicker when buffer completion is enabled for searching

[MrConnorKenway]

Make sure you have done the following

• Updated to the latest version of blink.cmp
• Searched for existing issues and documentation (try <C-k> on https://cmp.saghen.dev)

Bug Description

With default sources:

flicker.mov

With

sources = {
  default = { 'lsp', 'path' },
  cmdline = function()
    local type = vim.fn.getcmdtype()
    -- Commands
    if type == ':' or type == '@' then return { 'cmdline' } end
    return {}
  end
}

no.flicker.mov

Problem still exists when noice.nvim is disabled.

neovim version

0.10.3

blink.cmp version

0.10.0

[Saghen]

Are you still able to reproduce this on 0.12.*? If so, can you provide a repro.lua for this? I'm not able to reproduce this on my system with 0.10 or nightly with the default repro.lua

[jdrouhard]

Don't have time at this exact moment to make a repro.lua, but yes this problem still exists.

It looks like the problem is with drawing the completion menu floating window specifically for command line completions. I can reproduce this simply by using the default blink config (so cmdline has the buffer source enabled), and then typing '/' and a search term with incsearch on. As I type, the incsearch highlights flicker. Disable cmdline sources (so no more blink floating window for the cmdline), flicker disappears.

[MrConnorKenway]

Are you still able to reproduce this on 0.12.*? If so, can you provide a repro.lua for this? I'm not able to reproduce this on my system with 0.10 or nightly with the default repro.lua

Yes. I use the same repro.lua you provided:

flicker.mov

[Saghen]

I've tried on the repro.lua on 0.10/nightly and on foot, kitty and alacritty but I still can't reproduce. If someone is able to, try playing around with the calls to nvim__redraw

[jdrouhard]

Spent a better part of the day debugging this and finally nailed down exactly what was causing it. PR to fix is up and linked to this issue.

[jdrouhard]

Ugh, @Saghen hate to say this but the PR improved the flicker a little but didn't actually fully fix it. We may want to reopen this until I can dig into this more.

[jdrouhard]

Or, we can make a new issue. It's only flickering now when cursorline is enabled and it only flickers the current match (not the other matches on the screen)

[jdrouhard]

Lets do that @Saghen - I'll open a new issue to track flickering specifically with cursorline which only affects the current line's incsearch (not the other hlsearch highlights). This is still resolved for the most part with my PR.