Fix 2281 aliases ignore pre post add actions #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded to an Alias() node, if there was no action specified when that node was created
mwichmann
reviewed
Jan 21, 2025
SCons/Node/Alias.py
Outdated
| if len(self.executor.post_actions) + len(self.executor.pre_actions) > 0: | ||
| # Only actually call Node's build() if there are any | ||
| # pre or post actions. | ||
| # Alias node's will get 1 action and Alias.build() |
There was a problem hiding this comment.
nit: no apostrophe on line 112, plural not possessive.
|
Looks okay to me. I will revise #4672 after this merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an Alias node was being created with no action specified, any actions added with AddPreAction() or AddPostAction() were being ignored because the Alias nodes build() method didn't do anything.
Now we'll check if there are any pre or post actions on the executor and if so call the real build() method from Node.Node.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).