Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse and lower let-else statements #3468

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Parse and lower let-else statements #3468

wants to merge 5 commits into from

Conversation

CohenArthur
Copy link
Member

Fixes #3459
Fixes #3460

@CohenArthur
ast: Add optional diverging else to AST::LetStmt
b4887c2 
gcc/rust/ChangeLog:

	* ast/rust-stmt.h (class LetStmt): Add optional expression for diverging else.
	* ast/rust-ast-builder.cc (Builder::let): Use new API.
@CohenArthur
parser: Parse let-else statements
0ef4c42 
gcc/rust/ChangeLog:

	* parse/rust-parse-impl.h (Parser::parse_let_stmt): Add new parsing in case of `else` token.
@CohenArthur
dump: Handle let-else properly
22ea657 
gcc/rust/ChangeLog:

	* ast/rust-ast-collector.cc (TokenCollector::visit): Add handling for diverging else
	expression.
@CohenArthur
name-resolution: Handle let-else properly
0402a71 
gcc/rust/ChangeLog:

	* resolve/rust-ast-resolve-stmt.h: Add handling for diverging else.
	* resolve/rust-late-name-resolver-2.0.cc (Late::visit): Likewise.
@CohenArthur
lower: Handle let-else properly
e959e86 
gcc/rust/ChangeLog:

	* hir/tree/rust-hir-stmt.h (class LetStmt): Add optional diverging else expression.
	* hir/tree/rust-hir-stmt.cc: Likewise.
	* hir/rust-ast-lower-stmt.cc (ASTLoweringStmt::visit): Add handling for lowering
	diverging else.
@CohenArthur CohenArthur requested review from philberty and P-E-P March 5, 2025 15:43
@CohenArthur CohenArthur mentioned this pull request Mar 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philberty philberty Awaiting requested review from philberty

@P-E-P P-E-P Awaiting requested review from P-E-P

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lower let-else statements properly Parse let-else statements
1 participant
@CohenArthur