Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't wrap and serialize functions that are attribute values #7284

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Jan 27, 2025

Do not convert attribute value function call to _fnSignal. This way it will create component-level subscription like in v1 and should work after resuming the application

@Varixo Varixo self-assigned this Jan 27, 2025
@Varixo Varixo requested a review from a team as a code owner January 27, 2025 14:47
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: ff9e6a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo linked an issue Jan 27, 2025 that may be closed by this pull request
Copy link

pkg-pr-new bot commented Jan 27, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7284
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7284
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7284
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7284

commit: ff9e6a1

Copy link
Contributor

github-actions bot commented Jan 27, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview ff9e6a1

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit c335b49 into build/v2 Jan 27, 2025
22 checks passed
@wmertens wmertens deleted the v2-dont-wrap-fn branch January 27, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[🐞] V2 - Cannot serialize function
2 participants