Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export SVG type #7222

Merged
merged 9 commits into from
Feb 7, 2025
Merged

fix: export SVG type #7222

merged 9 commits into from
Feb 7, 2025

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Jan 2, 2025 •
edited
Loading

fixes #7212

What is it?

export a type of SVGAttributes.

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested review from a team as code owners January 2, 2025 03:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3936c70

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 2, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7222

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7222

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7222

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7222

commit: 3936c70

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 129803d

@JerryWu1234
Copy link
Contributor Author

@wmertens please help to review this PR

wmertens
wmertens requested changes Feb 6, 2025
View reviewed changes
@wmertens wmertens enabled auto-merge (squash) February 7, 2025 06:41
@wmertens wmertens merged commit 60c8202 into QwikDev:build/v2 Feb 7, 2025
19 checks passed
@github-actions github-actions bot mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JerryWu1234 @wmertens