Rework security policy #3544
Closed
Rework security policy #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merwok
commented
Dec 14, 2019
| @@ -2086,7 +2086,10 @@ def __init__(self, permitted=True): | |||
| def identify(self, request): | |||
| return 123 | |||
There was a problem hiding this comment.
Should change this for an instance of a named tuple or tiny class.
merwok
commented
Dec 14, 2019
| @@ -2086,7 +2086,10 @@ def __init__(self, permitted=True): | |||
| def identify(self, request): | |||
| return 123 | |||
|
|
|||
| def permits(self, request, context, identity, permission): | |||
| def authenticated_userid(self, request): | |||
| return 123 | |||
There was a problem hiding this comment.
See discussion about userid being required to be a string
merwok
commented
Dec 14, 2019
| :func:`pyramid.security.principals_allowed_by_permission`. | ||
|
|
||
| .. versionadded:: 1.4 | ||
| The ``remember_result`` argument. | ||
|
|
||
| .. versionadded:: 1.4 | ||
| The ``forget_result`` argument. | ||
|
|
||
| .. versionchanged:: 2.0 | ||
| Removed ``groupids`` argument and doc about effective principals. |
There was a problem hiding this comment.
Review other changed methods to see if we need more versionchanged notes (for example the top-level functions in pyramid.security below)
|
Replaced by #3545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3520 for #3422
Follow-up to PR #3465
__str__requirement for identity #3520 (comment))