Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set pyramid_tm.explicit_manager in the configuration #3059

Merged
merged 7 commits into from
Jun 10, 2017

Conversation

chrismorales
Copy link

No description provided.

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there were some omitted files:

  • docs/tutorials/wiki2/src/authorization/tutorial/models/__init__.py
  • docs/tutorials/wiki/src/*/tutorial/models/__init__.py (6 files)
  • in docs/tutorials, a regex search of literalinclude.*__init__.py found 20 matches in 5 files that need to be reviewed for possible line number realignment

@stevepiercy
Copy link
Member

@chrismorales 1 down, 2 to go.

  • docs/tutorials/wiki/src/*/tutorial/models/init.py (6 files)
  • in docs/tutorials, a regex search of literalinclude.*init.py found 20 matches in 5 files that need to be reviewed for possible line number realignment

@mmerickel mmerickel added this to the 1.9 milestone Jun 9, 2017
@mmerickel
Copy link
Member

Is this done? I will probably try to finish this and add in #3048 and #3042 at the same time if I can find a block of time this weekend. These issues are the only real hold up to a new release right now.

@stevepiercy
Copy link
Member

If I don't hear anything from @chrismorales today, I'll pick this up, probably late tonight.

@mmerickel
Copy link
Member

Ok well like I said the other 2 issues I linked are the same thing so everything should probably be done at once for simplicity with the exception that this PR is almost complete so maybe just finish it off and then do the other 2 as one change.

@stevepiercy
Copy link
Member

Yup, that's my plan.

@stevepiercy stevepiercy dismissed their stale review June 10, 2017 19:48

Merging progress to date; will pick up remainder of docs in #3081 checklist

@stevepiercy stevepiercy merged commit a503511 into Pylons:master Jun 10, 2017
@stevepiercy
Copy link
Member

Refs #3052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants