Fix #1603, add closest predicate name in error message #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -152,7 +152,16 @@ def make(self, config, **kw): | |||
| weights.append(1 << n + 1) | |||
| preds.append(pred) | |||
| if kw: | |||
| raise ConfigurationError('Unknown predicate values: %r' % (kw,)) | |||
| from difflib import get_close_matches | |||
There was a problem hiding this comment.
Comment for future reviewers, import statement inside the function so that we only have to import it when we are about to raise a ConfigurationError.
digitalresistor
approved these changes
May 22, 2017
mmerickel
approved these changes
May 22, 2017
|
Wow! :D |
This was referenced Jun 20, 2017
This was referenced Jun 27, 2017
This was referenced Jun 30, 2017
This was referenced Jul 10, 2017
This was referenced Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1603, add closest predicate name in error message