Scripts optparse to argparse #2864

stevepiercy · 2016-12-11T06:55:44Z

mmerickel · 2016-12-11T07:33:13Z

pyramid/scripts/prequest.py

-        app = self.get_app(app_spec, self.options.app_name,
-                options=parse_vars(self.args[2:]))
+        app = self.get_app(app_spec, self.args.app_name,
+                options=self.args.config_vars)


missing parse_vars

mmerickel · 2016-12-11T07:37:38Z

pyramid/scripts/pviews.py

-    parser = optparse.OptionParser(
-        usage,
+    parser = argparse.ArgumentParser(
+        prog="pviews",


drop prog argument

mmerickel · 2016-12-11T07:38:15Z

pyramid/tests/test_scripts/test_proutes.py

@@ -38,7 +38,8 @@ def _makeConfig(self, *arg, **kw):
    def test_good_args(self):
        cmd = self._getTargetClass()([])
        cmd.bootstrap = (dummy.DummyBootstrap(),)
-        cmd.args = ('/foo/bar/myapp.ini#myapp', 'a=1')
+        cmd.args.config_uri = ('/foo/bar/myapp.ini#myapp',)


not a tuple

mmerickel · 2016-12-11T07:38:48Z

pyramid/tests/test_scripts/test_pserve.py

        inst = self._makeOne()
-        inst.args = ['foo', 'a=1', 'b=2']
-        result = inst.get_options()
+        inst.args.config_args = ['a=1', 'b=2']


config_vars

stevepiercy · 2016-12-11T12:46:41Z

ptweens and pviews are ready for review.

I'm stuck on pshell, and I don't know where to go next. I think I got pshell to run as follows. Using my local project from the starter scaffold, I did pip install -e . to pull in all the latest changes of the p* scripts, then tried to run ../../env35/bin/pshell development.ini. This started an interactive Python shell.

There are probably mistakes in my pshell, too, the latest of which is committed and pushed here.

In the tests (latest also committed and pushed), there's patch_* stuff in _makeOne(). I tried debugging the test, but I could not figure out where to look or what it does, so I don't know how to fix the tests.

mmerickel · 2016-12-11T18:28:56Z

You need to fix the _makeOne method to do the right thing. It doesn't match up with all of the changes you're making.

stevepiercy · 2016-12-12T07:20:21Z

All things pass, except docs continue to fail to build (due to Sphinx/docutils bug), but build locally. Hopefully Sphinx will make a new release with the fix.
https://travis-ci.org/Pylons/pyramid/jobs/183174559#L700

Ready for final review. Can you believe it?

- add sphinxcontrib-autoprogram - attempt to render output of pcreate, but be unsuccessful

- restore argv - use standard Python syntax for string formatting

- PEP8

…it from pdistreport.rst

…eing emitted for invalid commands

digitalresistor · 2016-12-14T17:33:11Z

I'll review this in a little bit.

digitalresistor

Just a simple comment, besides that, LGTM. @mmerickel I'll leave the merging to you in case you have any last minute requests.

digitalresistor · 2016-12-15T06:01:05Z

docs/conf.py

@@ -51,11 +51,11 @@ def nothing(*arg):
 extensions = [
    'sphinx.ext.autodoc',
    'sphinx.ext.doctest',
+    'repoze.sphinx.autointerface',


Is there a particular reasoning for the ordering of these? Or can they be alphabetized?

mmerickel · 2016-12-15T06:27:24Z

Thanks for powering through @stevepiercy

stevepiercy · 2016-12-15T06:32:02Z

Thank you for your guidance and patience. Hope the multiple facepalm wounds heal.

stevepiercy · 2016-12-15T06:36:07Z

Closes #2804

stevepiercy mentioned this pull request Dec 11, 2016

Scripts optparse to argparse #2842

Closed

mmerickel requested changes Dec 11, 2016

View reviewed changes

stevepiercy added this to the 1.8 milestone Dec 11, 2016

stevepiercy self-assigned this Dec 11, 2016

stevepiercy added the needs-work label Dec 11, 2016

stevepiercy mentioned this pull request Dec 11, 2016

Replace sphinxcontrib-programoutput with another package #2804

Closed

stevepiercy force-pushed the scripts-optparse-to-argparse branch from 22db456 to ed1764d Compare December 14, 2016 00:01

stevepiercy added 20 commits December 13, 2016 16:24

convert pcreate and pdistreport to use argparse

b7f994c

- add sphinxcontrib-autoprogram - attempt to render output of pcreate, but be unsuccessful

fix autoprogram argument

bde0ef1

- restore argv - use standard Python syntax for string formatting

make usage parseable by argparse

3fb84e9

- PEP8

make usage parseable by argparse

f33a50c

still fumbling around with autoprogram, not successful

b2f3ed0

drop '.py' from :prog: argument

cae3840

move parser outside of main into own function get_parser(), and call …

0c208dd

…it from pdistreport.rst

remove duplicitous headings

e5b871d

rename local

1efb311

indent 4 spaces

6b229c9

use argparse in prequest; use autoprogram

9a22d66

use argparse in prequest; use autoprogram

83ebd45

use argparse in proutes; use autoprogram

616f40a

add line feed to avoid Sphinx error

506d3c7

fix quote mismatch

894534b

use argparse and autoprogram for pserve

6e14f62

use argparse and autoprogram for pshell

5ad647c

use argparse and autoprogram for ptweens

7dd4214

use argparse and autoprogram for ptviews

812bc62

restore slice of argv

c47bfc6

stevepiercy added 3 commits December 13, 2016 23:31

fix faulty logic in prequest and pviews

258f848

move deprecation warning further down in the logic to avoid it from b…

f5ae217

…eing emitted for invalid commands

PEP8

91db736

mmerickel approved these changes Dec 14, 2016

View reviewed changes

digitalresistor self-requested a review December 14, 2016 17:32

digitalresistor reviewed Dec 15, 2016

View reviewed changes

mmerickel merged commit 5b5b20b into Pylons:master Dec 15, 2016

mmerickel added a commit that referenced this pull request Dec 15, 2016

changelog for #2864

4c8eb25

stevepiercy deleted the scripts-optparse-to-argparse branch December 15, 2016 06:36

This was referenced Jan 22, 2017

Update pyramid to 1.8 pypi/warehouse#1684

Closed

Initial Update Kotti/Kotti#522

Closed

Update pyramid to 1.8.1 pypi/warehouse#1699

Closed

glasserc mentioned this pull request Feb 17, 2017

Make serve recipe is failing Kinto/kinto#1092

Closed

pyup-bot mentioned this pull request Feb 26, 2017

Pin pyramid to latest version 1.8.2 nicfit/MishMash#35

Merged

pyup-bot mentioned this pull request Apr 30, 2017

Pin pyramid to latest version 1.8.3 nicfit/MishMash#94

Merged

This was referenced Jun 26, 2017

Scheduled weekly dependency update for week 26 openstax/cnx-deploy#337

Closed

Initial Update mozilla-services/shavar#100

Merged

pyup-bot mentioned this pull request Jul 3, 2017

Scheduled weekly dependency update for week 27 openstax/cnx-deploy#341

Closed

This was referenced Jul 10, 2017

Scheduled weekly dependency update for week 28 openstax/cnx-deploy#342

Closed

Scheduled weekly dependency update for week 29 openstax/cnx-deploy#344

Closed

pyup-bot mentioned this pull request Jul 24, 2017

Scheduled weekly dependency update for week 30 openstax/cnx-deploy#346

Closed

This was referenced Sep 29, 2017

Initial Update openstax/cnx-deploy#385

Merged

Update pyramid to 1.9.1 OnroerendErfgoed/pyramid_skosprovider#37

Closed

Update pyramid to 1.9.1 OnroerendErfgoed/pyramid_urireferencer#27

Merged

pyup-bot mentioned this pull request Dec 12, 2017

Pin pyramid to latest version 1.9.1 openstax/cnx-press#6

Merged

pyup-bot mentioned this pull request Jun 30, 2020

Pin pyramid to latest version 1.10.4 camptocamp/c2cgeoportal#6622

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scripts optparse to argparse #2864

Scripts optparse to argparse #2864

stevepiercy commented Dec 11, 2016

mmerickel Dec 11, 2016

mmerickel Dec 11, 2016

mmerickel Dec 11, 2016

mmerickel Dec 11, 2016

stevepiercy commented Dec 11, 2016

mmerickel commented Dec 11, 2016

stevepiercy commented Dec 12, 2016

digitalresistor commented Dec 14, 2016

digitalresistor left a comment

digitalresistor Dec 15, 2016

mmerickel commented Dec 15, 2016

stevepiercy commented Dec 15, 2016

stevepiercy commented Dec 15, 2016

Scripts optparse to argparse #2864

Scripts optparse to argparse #2864

Conversation

stevepiercy commented Dec 11, 2016

mmerickel Dec 11, 2016

Choose a reason for hiding this comment

mmerickel Dec 11, 2016

Choose a reason for hiding this comment

mmerickel Dec 11, 2016

Choose a reason for hiding this comment

mmerickel Dec 11, 2016

Choose a reason for hiding this comment

stevepiercy commented Dec 11, 2016

mmerickel commented Dec 11, 2016

stevepiercy commented Dec 12, 2016

digitalresistor commented Dec 14, 2016

digitalresistor left a comment

Choose a reason for hiding this comment

digitalresistor Dec 15, 2016

Choose a reason for hiding this comment

mmerickel commented Dec 15, 2016

stevepiercy commented Dec 15, 2016

stevepiercy commented Dec 15, 2016