Update MSRV; disallow long IDs #28434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here I'm assuming a field can hold 250 bits, but in principle that could vary. |
mikebenfield
force-pushed
the
long-ids
branch
2 times, most recently
from
31a8e4a to
154bc10
Compare
d0cd
requested changes
Nov 6, 2024
mikebenfield
force-pushed
the
long-ids
branch
from
154bc10 to
47d78cd
Compare
SnarkVM requires that identifiers fit in a field element.
mikebenfield
force-pushed
the
long-ids
branch
from
47d78cd to
b66db03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages.
Updating the minimum supported Rust version in other crates in the workspace was missed when updating it in the main
Cargo.toml.Also, SnarkVM will give a confusing parse error on identifiers that are too long, so we should disallow them here.