Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Futures in Tuples #28316

Merged
merged 2 commits into from
Aug 13, 2024
Merged

[Fix] Futures in Tuples #28316

merged 2 commits into from
Aug 13, 2024

Conversation

evan-schott
Copy link
Contributor

Fixes #28312

Design choices:

  • Using eq_flat_relaxed over eq_flat in TYC:
    • ST makes sure that if we have multiple structs of the same name, then there is an error (before TYC starts).
    • eq_flat for strict equality, eq_flat_relaxed for relaxed equality. (When future is not explicit or struct matches but program origin is different).
  • For change we could use .eq_flat_relaxed instead of self.check_eq_types but I thought it would be nice to have consistent usage of check_eq_types throughout TYC.

@evan-schott evan-schott requested a review from d0cd August 10, 2024 02:36
@d0cd d0cd merged commit 4a7b062 into mainnet Aug 13, 2024
8 of 9 checks passed
@d0cd d0cd deleted the fix/tuple-future branch August 13, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Type mismatch when awaiting Future from tuple
2 participants