Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] CLI cleanup #28146

Merged
merged 16 commits into from
Jul 2, 2024
Merged

[Feat] CLI cleanup #28146

merged 16 commits into from
Jul 2, 2024

Conversation

evan-schott
Copy link
Contributor

  • Features:
    • Deployment variable and constraint limit now enforced in leo deploy.
    • Easier interaction with CLI by enabling default usage of network in .env.
    • Closes [Feature] Add Canary network to CLI #28082: Adds support for canary network.
    • Changed base to latest commit on mainnet-staging (AleoNet).
  • Open questions:
    • How should we implement snarkVM errors?
    • What is the best advice to give for reducing constraints and variables?

@evan-schott evan-schott requested a review from d0cd June 20, 2024 21:21
d0cd
d0cd requested changes Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions for cleanup. We should double check that all unwraps in the CLI are safe.

examples/basic_bank/run.sh Outdated
@@ -20,6 +20,7 @@ fi
echo "
NETWORK=mainnet
PRIVATE_KEY=APrivateKey1zkp8CZNn3yeCseEtxuVPbDCwSyhGW6yZKUYKfgXmcpoGPWH
ENDPOINT=https://api.explorer.aleo.org/v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the example ENDPOINTs be https://localhost:3030 instead to make testing easier?

@evan-schott evan-schott requested a review from d0cd June 25, 2024 20:15
d0cd
d0cd approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a minor formatting suggestion and the snarkVM rev should be updated to the latest version.

@d0cd d0cd merged commit 94382c4 into mainnet Jul 2, 2024
13 checks passed
@d0cd d0cd deleted the feat/simplify-cli branch July 2, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0cd d0cd d0cd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add Canary network to CLI
2 participants
@evan-schott @d0cd