Fix #1046. #1048
Merged
Fix #1046. #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! This PR re-introduces the issue of running into the blocking-during-resize bug in macos (see rust-windowing/winit#219) but this is already a problem in all the other examples anyway, and it's probably worth not getting swamped on platforms that emit loads of events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1046. Batch events together so that we don't end up lagging behind user input. Essentially reverted back to the behavior before e268425. I didn't include the logic to wait 16ms between updates because it's my understanding that setting vsync on the window will cause the
target.finish()call to block and limit updates to 60fps. Correct me if I'm mistaken.