Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Maven Wrapper for Mac #58

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Fix Maven Wrapper for Mac #58

merged 2 commits into from
Mar 14, 2022

Conversation

LordRekishi
Copy link
Contributor

Fix #56 so mvnw commands work for Mac users.
Updated readme file to incorporate maven wrapper commands
Thus not needing to install maven manually

@LordRekishi
Copy link
Contributor Author

Fix #49

@LordRekishi LordRekishi linked an issue Mar 14, 2022 that may be closed by this pull request
Make maven wrapper work #49
Closed
@helenahalldiniths helenahalldiniths self-requested a review March 14, 2022 16:24
helenahalldiniths
helenahalldiniths approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@helenahalldiniths helenahalldiniths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the code and followed the deployment instruction, it works as expected. Good job!

@LordRekishi LordRekishi merged commit 2748a34 into main Mar 14, 2022
@LordRekishi LordRekishi deleted the Issue56 branch March 14, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helenahalldiniths helenahalldiniths helenahalldiniths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Maven Wrapper for Mac users Make maven wrapper work
2 participants
@LordRekishi @helenahalldiniths