Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalDateTime fix - Issue 41 #42

Merged
merged 4 commits into from
Mar 14, 2022
Merged

LocalDateTime fix - Issue 41 #42

merged 4 commits into from
Mar 14, 2022

Conversation

LordRekishi
Copy link
Contributor

Fix #41

@LordRekishi
Copy link
Contributor Author

To check in Insomnia

Endpoints:

POST
http://localhost:8080/crimes
http://localhost:8080/criminals
http://localhost:8080/victims

JSON commands

Crime:

{
	"name": "Theft of wallet",
	"time": "2022-03-11 10:10"
}

Criminal

{
	"firstName": "Jane",
	"lastName": "Doe",
	"dateOfBirth": "1980-03-03"
}

Victim

{
	"firstName": "John",
	"lastName": "Doe",
	"dateOfBirth": "1997-10-10"
}

@FelixJacobsen FelixJacobsen self-requested a review March 10, 2022 19:36
Copy link
Contributor

@FelixJacobsen FelixJacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, but I'm wondering if we really want to include the exact time with the date in Crime? Usually date isn't a part of time? We might should consider making time and date into two seperate fields.

@helenahalldiniths
Copy link
Contributor

I think it works well both with and without time! Maybe it isn't that important? Lets use this version and change it later on i we want to?

@LordRekishi LordRekishi merged commit 090e99b into main Mar 14, 2022
@LordRekishi LordRekishi deleted the Issue41 branch March 14, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Json -> LocalDate
3 participants