Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto Parallel] Fix ckpt_converter for auto_parallel #9136

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

zhangyuqin1998
Copy link
Contributor

PR types

Others

PR changes

Others

Description

修复混合并行下,加载master_weight不正确的问题
修复动转静下,使用master_weight时,param未被加载到scope的问题

Copy link

paddle-bot bot commented Sep 13, 2024

Thanks for your contribution!

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.29%. Comparing base (f4cff96) to head (0d04e0f).
Report is 248 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/auto_trainer.py 0.00% 3 Missing ⚠️
paddlenlp/trainer/utils/ckpt_converter.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9136      +/-   ##
===========================================
- Coverage    53.54%   53.29%   -0.25%     
===========================================
  Files          652      652              
  Lines       106540   105483    -1057     
===========================================
- Hits         57043    56217     -826     
+ Misses       49497    49266     -231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit e9338c2 into PaddlePaddle:develop Sep 14, 2024
5 of 12 checks passed
lvdongyi pushed a commit to lvdongyi/PaddleNLP that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants