[Benchmark] Fix amp level bug in some gpt tests #9116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9116 +/- ##
===========================================
- Coverage 53.34% 53.32% -0.02%
===========================================
Files 652 652
Lines 105401 105436 +35
===========================================
Hits 56222 56222
- Misses 49179 49214 +35 ☔ View full report in Codecov by Sentry. |
fightfat
reviewed
Sep 11, 2024
|
|
||
| if [ $FLAGS_enable_pir_api == 1 ]; then | ||
| if [ ${level} == "o3" ]; then | ||
| ${level}="o2" |
fightfat
reviewed
Sep 12, 2024
| @@ -35,6 +35,18 @@ function _set_params(){ | |||
| sharding_degree=${10:-"1"} # (可选) | |||
| sharding_stage=${11:-"1"} # (可选)sharding case | |||
| level=${12:-"o1"} # o1|o2|o3 | |||
|
|
|||
| if [ $FLAGS_enable_pir_api == 1 ]; then | |||
There was a problem hiding this comment.
这里改成这样吧， if [[ $FLAGS_enable_pir_api == "1" || $FLAGS_enable_pir_api == "True" ]]; then
| @@ -35,6 +35,18 @@ function _set_params(){ | |||
| sharding_degree=${10:-"1"} # (可选) | |||
| sharding_stage=${11:-"1"} # (可选)sharding case | |||
| level=${12:-"o1"} # o1|o2|o3 | |||
|
|
|||
| if [ $FLAGS_enable_pir_api == 1 ]; then | |||
There was a problem hiding this comment.
这里改成这样吧， if [[ $FLAGS_enable_pir_api == "1" || $FLAGS_enable_pir_api == "True" ]]; then
ZHUI
changed the title
ZHUI
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Fix amp level bug in some gpt tests