Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM] fix train on npu #9101

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

SylarTiaNII
Copy link
Contributor

@SylarTiaNII SylarTiaNII commented Sep 6, 2024

PR types

Bug fixes

PR changes

Others

Description

fix train on npu since comm using bool is not supported in HCCL

Copy link

paddle-bot bot commented Sep 6, 2024

Thanks for your contribution!

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit d245d07 into PaddlePaddle:develop Sep 6, 2024
7 of 10 checks passed
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.47%. Comparing base (c90dc87) to head (cd1670c).
Report is 217 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9101      +/-   ##
===========================================
+ Coverage    53.34%   53.47%   +0.13%     
===========================================
  Files          652      652              
  Lines       105401   105401              
===========================================
+ Hits         56222    56367     +145     
+ Misses       49179    49034     -145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ckl117 pushed a commit to ckl117/PaddleNLP that referenced this pull request Sep 9, 2024
SylarTiaNII added a commit to SylarTiaNII/PaddleNLP that referenced this pull request Sep 9, 2024
JunnYu pushed a commit that referenced this pull request Sep 9, 2024
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants